Adjust items type for IncrementalStreamResult and FormattedIncrementalStreamResult#4483
Open
jerelmiller wants to merge 2 commits intographql:nextfrom
Open
Adjust items type for IncrementalStreamResult and FormattedIncrementalStreamResult#4483jerelmiller wants to merge 2 commits intographql:nextfrom
items type for IncrementalStreamResult and FormattedIncrementalStreamResult#4483jerelmiller wants to merge 2 commits intographql:nextfrom
Conversation
jerelmiller
commented
Sep 20, 2025
| > { | ||
| errors?: ReadonlyArray<GraphQLFormattedError>; | ||
| items: TData; | ||
| items: ReadonlyArray<TData>; |
Author
There was a problem hiding this comment.
Everything else seems to use ReadonlyArray, so I figured this should probably be the same instead of Array like it was before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the following:
When providing a generic to
*IncrementalResult, theitemsproperty on*IncrementalStreamResultis typed incorrect due to theArray<*>being part of the default type instead of theitemsproperty. This means calling array methods onitemsresults in a TypeScript error since TypeScript doesn't know its an array. This is incorrect sinceitemscan only be an array type and nothing else. Here is the reproduction in TS Playground.This PR fixes this issue by moving the
Array<*>wrapper to theitemstype so that this works as expected.